Pass to block dynamic dimensions of operands of iree_linalg_ext.attention.
#18874
+1,117
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pse_shape` into `flow.dispatch.tensor.load/store`. This also cleans up the implementation of these patterns to avoid using templated code that is hard to read/maintain. Signed-off-by: MaheshRavishankar <[email protected]>
…ntion`. The use of `IntegerRangeAnalysis` and `IntegerDivisibilityAnalysis` gives range and divisibility information for constants passed to the dispatch. This can be used to infer the range and divisibility information for all tensor values in the dispatch. This PR adds an analysis to do this. This analysis is then used to expand the dimensions of operands of the attention operation that are dynamic, but are known to be divisible by a compile-time static value. This gets the operations into a form that can be compiled by the AMDGPU backend and target the mfma intrinsics. Signed-off-by: MaheshRavishankar <[email protected]>
|
Depends on #18873 . Please review only the top commit |
MaheshRavishankar
requested review from
qedawkins,
Groverkss and
stellaraccident
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
IntegerRangeAnalysisandIntegerDivisibilityAnalysisgives range and divisibility information for constants passed to the
dispatch. This can be used to infer the range and divisibility
information for all tensor values in the dispatch. This PR adds an
analysis to do this.
This analysis is then used to expand the dimensions of operands of the
attention operation that are dynamic, but are known to be divisible by
a compile-time static value. This gets the operations into a form that
can be compiled by the AMDGPU backend and target the mfma intrinsics.
Signed-off-by: MaheshRavishankar [email protected]