Towards RPE #475
Draft
Towards RPE #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftynse
commented
Feb 7, 2025
iree/turbine/kernel/wave/codegen.py
Outdated
| subs[-1] = ( | ||
| subs[-1][0], | ||
| start_indices_orig[-1] + idxc.iota(elements_per_thread), | ||
| start_indices_orig[-1], # + idxc.iota(elements_per_thread), |
There was a problem hiding this comment.
IMPORTANT: iota is still needed when offset uses scalar / broadcasted symbols, but not needed when offset uses vector symbols.
Not sure of the repercussions on the design
| @@ -1420,6 +1420,7 @@ def check_is_mapping_contiguous( | |||
| return True | |||
|
|
|||
| # TODO: Better dyn vals analysis. | |||
| # TODO TODO TODO: we also need to check if there are additional sybols in the mapping | |||
This implements (causal) ALiBi, attention with linear biases, following the paper "Train Short, Test Long: Attention with Linear Biases Enables Input Length Extrapolation" by Press et.al in ICLR 2022. Signed-off-by: Alex Zinenko <[email protected]>
Signed-off-by: Alex Zinenko <[email protected]>
Signed-off-by: Alex Zinenko <[email protected]>
Signed-off-by: Nicolas Vasilache <[email protected]>
ftynse
force-pushed
the
users/alex/rpe
branch
from
3015755 to
a5a1818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.