Keep disambiguating number in expanded node name #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes get named like
add
,add_1
, etc to disambiguate ones with the same name. But the node naming in expansion throws away this suffix. I think it's helpful to leave it in, when viewing the IR. Nodes don't have to have unique names, but it's nice if they do.I just updated one lit test here as an example because I want to confirm that this change is desirable before doing the work of updating the rest.
DO_NOT_COMMIT: I haven't updated all the lit tests
skip-ci: I know that some of the lit tests are failing. Want to get agreement before updating them.