Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep disambiguating number in expanded node name #437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GMNGeoffrey
Copy link
Contributor

Nodes get named like add, add_1, etc to disambiguate ones with the same name. But the node naming in expansion throws away this suffix. I think it's helpful to leave it in, when viewing the IR. Nodes don't have to have unique names, but it's nice if they do.

I just updated one lit test here as an example because I want to confirm that this change is desirable before doing the work of updating the rest.

DO_NOT_COMMIT: I haven't updated all the lit tests

skip-ci: I know that some of the lit tests are failing. Want to get agreement before updating them.

Nodes get named like `add`, `add_1`, etc to disambiguate ones with the
same name. But the node naming in expansion throws away this suffix. I
think it's helpful to leave it in, when viewing the IR. Nodes don't have
to have unique names, but it's nice if they do.
I just changed one lit test here as an example because I want to confirm
that this change is desirable before doing the work of updating the
rest.
@GMNGeoffrey GMNGeoffrey requested a review from harsh-nod January 30, 2025 00:14
@GMNGeoffrey
Copy link
Contributor Author

Huh, it doesn't seem like the skip-ci trailer works in this repo. Note that the turbine contributing guidelines point to the IREE contributing guidelines, which document the ci control options. You should perhaps consider adding them to turbine. Whoever came up with them created a really cool and useful feature 😜 <-- @ScottTodd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant