Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate IREE at openxla/iree@89a41d9 #255

Closed
wants to merge 2 commits into from

Conversation

simon-camp
Copy link
Collaborator

Updates IREE usage to match iree-org/iree@89a41d9 and candidate-20230620.558, respectively.

Updates IREE usage to match iree-org/iree@89a41d9 and
candidate-20230620.558, respectively.
@simon-camp simon-camp requested a review from marbre June 20, 2023 13:17
@simon-camp simon-camp force-pushed the integrate branch 3 times, most recently from e99383b to 90d26ed Compare June 21, 2023 09:08
@lucas-camp
Copy link
Collaborator

lucas-camp commented Jun 21, 2023

The libopencm3 build fail with the error undefined reference to _fini. There are two possible solutions I came up with

@marbre
Copy link
Member

marbre commented Jun 21, 2023

The libopencm3 build fail with the error undefined reference to _fini'. There are two possible solutions I came up with

* Add `-specs=nano.specs` to [arm-none-eabi-gcc.cmake](https://github.com/iml130/iree-bare-metal-arm/blob/68e90077fe637e964d19e9a2354d74cf8caa19a2/build_tools/cmake/arm-none-eabi-gcc.cmake#L48)

* Add a stub implementation for `void _fini(void)` in the customized [vector.c](https://github.com/iml130/iree-bare-metal-arm/blob/main/third_party/libopencm3-custom/vector.c)

Please let us avoid -specs=nano.specs. So if there is no other solution, we can go for a stub implementation, but this should be added with a separate file.

@@ -115,6 +115,7 @@ set(IREE_BUILD_TESTS OFF)
set(IREE_BUILD_BINDINGS_TFLITE OFF)
set(IREE_HAL_DRIVER_DEFAULTS OFF)
set(IREE_HAL_EXECUTABLE_LOADER_DEFAULTS OFF)
set(IREE_HAL_EXECUTABLE_PLUGIN_DEFAULTS OFF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set(IREE_HAL_EXECUTABLE_PLUGIN_DEFAULTS OFF)
set(IREE_HAL_EXECUTABLE_PLUGIN_DEFAULTS OFF)
set(IREE_HAL_EXECUTABLE_PLUGIN_EMBEDDED_ELF ON)

@marbre
Copy link
Member

marbre commented Jul 17, 2023

The stub implementation for _fini() was added with #257. I assume this PR fails because IREE_HAL_EXECUTABLE_PLUGIN_EMBEDDED_ELF isn't set. Furthermore, it seems we should use iree_vm_list_get_buffer_view_assign() instead of `iree_vm_list_get_ref_deref(). Sending #258 therefore.

@marbre marbre closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants