-
-
Notifications
You must be signed in to change notification settings - Fork 48
Add the xkcd-script-mono #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For some reason, the outlines of Ē and Ő ended up changing. And it happened back at the pt5 stage. I feel like the newer version of Ő is the correct one. It might be a FontForge bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the non-mono form too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, lines 343 to 351 remain as before; it's a loop that converts all SVG files into glyphs, and glyphs with the same name are overwritten so that only the last one remains. Oh, that means at that moment, since the glyph exists, I can just copy and paste it into *.mono.
By the way, I don’t like writing things like ' + 60 * _line_fgs / 856' twice, so I want to reconsider the method for listing monospaced glyphs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll choose glyphs in two passes. The outlines we import the first time will be completely thrown away, but keeping all the outlines in the font object is a hassle, so I avoided it.