Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: send_async where possible #445

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

Includes:

  • a rename of asyncboundedchannel* to asyncchannel to accomodate unbounded channels
  • remove receipt logging with too much output

Includes:

- a rename of asyncboundedchannel* to asyncchannel to accomodate unbounded channels
- remove receipt logging with too much output
@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner November 16, 2023 23:39
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

@zeeshanlakhani zeeshanlakhani merged commit cb20747 into zl/jsonrpc Nov 17, 2023
23 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/async-naming-more-sends branch November 17, 2023 00:52
zeeshanlakhani pushed a commit that referenced this pull request Nov 29, 2023
Includes:

- a rename of `asyncboundedchannel*` to `asyncchannel` to accomodate
unbounded channels
- remove receipt logging with too much output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants