Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npm package to homestar runtime #434

Merged
merged 26 commits into from
Nov 29, 2023
Merged

feat: add npm package to homestar runtime #434

merged 26 commits into from
Nov 29, 2023

Conversation

hugomrdias
Copy link
Member

Description

adds npm packages to homestar-runtime.
CI is not integrated yet, there only manual instructions in the readme.

Type of change

  • New feature (non-breaking change that adds functionality)

@hugomrdias hugomrdias requested a review from a team as a code owner November 14, 2023 19:15
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good. I can help w/ the CI tmrw for non-windows first.

@hugomrdias hugomrdias force-pushed the feat/npm2 branch 2 times, most recently from 7cf7a9e to 86189ac Compare November 16, 2023 16:57
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one, super minor ask :).

@hugomrdias
Copy link
Member Author

done

@hugomrdias hugomrdias merged commit 476dc11 into zl/jsonrpc Nov 29, 2023
8 checks passed
@hugomrdias hugomrdias deleted the feat/npm2 branch November 29, 2023 17:57
zeeshanlakhani pushed a commit that referenced this pull request Nov 29, 2023
- adds npm packages to homestar-runtime.
- adds CI/CD to build and publish wrapper package and os specific packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants