Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: e2e workflow(s) run #223

Merged
merged 2 commits into from
Aug 4, 2023
Merged

refactor: e2e workflow(s) run #223

merged 2 commits into from
Aug 4, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Aug 3, 2023

  • Run IPVM workflow (json) files, return beginning info
  • Integrate Runner / worker bits, and pieces like
    • aborting workers
    • gc'ing handles
    • delayqueue/timing-wheel integration for expir(ed)/(ing) workflows
    • worker's can now send messages to the runner, for things like drop/abort
    • make db pool accessible within worker, so it's reusable upon creation and run
  • store receipts and workflow/receipt joint info as part of a DB transaction
  • runtime-specific proc-macro and worker builder for easier test integration
    • this now spins up db-related tests (involving workers/schedulers/the-runner) to use different sqlite dbs in parallel
  • flake fixins around cargo nextest and macos
  • Removes Error from Enum thiserror variants as per common usage
  • workflow info "storage" stores a timestamp for local use
  • remove bincode all around, and make rpc encoding/decoding work with messagepack
  • make database_url work as part as configuration or env (latter takes precedent)
  • more error-specific types

* Run IPVM workflow (json) files, return beginning info
* Integrate Runner / worker bits, and pieces like
  * aborting workers
  * gc'ing handles
  * delayqueue/timing-wheel integration for expir(ed)/(ing) workflows
  * worker's can now send messages to the runner, for things like drop/abort
  * make db pool accessible within worker, so it's reusable upon creation
    and run
* store receipts and workflow/receipt joint info as part of a DB transaction
* runtime-specific proc-macro and worker builder for easier test integration
  * this now spins up db-related tests (involving workers/schedulers/the-runner)
    to use different sqlite dbs in parallel
* flake fixins around cargo nextest and macos
* Removes `Error` from Enum thiserror variants as per common usage
* workflow info "storage" stores a timestamp for local use
* remove bincode all around, and make rpc encoding/decoding work
  with messagepack
* make database_url work as part as configuration or env (latter takes precedent)
* more error-specific types
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #223 (d95b05d) into main (4921bde) will decrease coverage by 1.46%.
The diff coverage is 74.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   76.83%   75.38%   -1.46%     
==========================================
  Files          57       64       +7     
  Lines        6057     5992      -65     
==========================================
- Hits         4654     4517     -137     
- Misses       1403     1475      +72     
Files Changed Coverage Δ
homestar-core/src/macros.rs 76.92% <ø> (ø)
homestar-core/src/unit.rs 31.25% <0.00%> (ø)
homestar-runtime/src/cli/error.rs 11.11% <0.00%> (ø)
homestar-runtime/src/db/utils.rs 0.00% <0.00%> (ø)
homestar-runtime/src/event_handler/event.rs 16.48% <0.00%> (+0.67%) ⬆️
homestar-runtime/src/network/ipfs.rs 16.66% <ø> (-13.57%) ⬇️
homestar-runtime/src/network/rpc/error.rs 0.00% <0.00%> (ø)
homestar-runtime/src/network/swarm.rs 55.55% <0.00%> (+3.70%) ⬆️
homestar-wasm/src/error.rs 0.00% <0.00%> (ø)
homestar-wasm/src/io.rs 42.85% <0.00%> (ø)
... and 33 more

... and 1 file with indirect coverage changes

@zeeshanlakhani zeeshanlakhani merged commit 7d3f50f into main Aug 4, 2023
19 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/runner-workflows branch August 4, 2023 06:35
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant