Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move away from inner-join, count up unique receipts for workflow info #188

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Jul 11, 2023

Description

This PR essentially makes progress count monotonic by changing up the inner join and storing receipt cids when grabbing info over libp2p.

Type of change

  • Refactor (non-breaking change that updates existing functionality)

…kflow info

This PR essentially makes progress count monotonic by changing up the inner join
and storing receipt cids when grabbing info over libp2p.
@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner July 11, 2023 02:03
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #188 (f2bff7e) into main (b1c76d2) will decrease coverage by 0.02%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   47.46%   47.44%   -0.02%     
==========================================
  Files          54       54              
  Lines        2482     2487       +5     
  Branches      606      608       +2     
==========================================
+ Hits         1178     1180       +2     
- Misses        926      928       +2     
- Partials      378      379       +1     
Impacted Files Coverage Δ
homestar-runtime/src/db.rs 41.37% <0.00%> (-3.07%) ⬇️
homestar-runtime/src/runner.rs 69.01% <ø> (ø)
homestar-runtime/src/workflow/info.rs 60.71% <0.00%> (-0.44%) ⬇️
homestar-runtime/src/worker.rs 51.02% <100.00%> (ø)

... and 2 files with indirect coverage changes

@zeeshanlakhani zeeshanlakhani merged commit 7376c05 into main Jul 11, 2023
12 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/db-info branch July 11, 2023 03:07
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant