Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: error handling with thiserror, anyhow for runtime only #139

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

Closes #62

This PR includes:

  • flake commands for helpful shortcuts
  • move to cargo nextest
  • worker tests
  • addition of workspace macros bail and ensure for internal error handling
  • moves general workflow structure to homestar-core, with generic handling, and allows for further building blocks

Closes #62

This PR includes:

* flake commands for helpful shortcuts
* move to cargo nextest
* worker tests
* addition of workspace macros bail and ensure for internal error handling
* moves general workflow structure to homestar-core, with generic handling, and
  allows for further building blocks
@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner June 14, 2023 07:00
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #139 (fce6ad5) into main (ec5dd3a) will decrease coverage by 0.48%.
The diff coverage is 39.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   49.47%   48.99%   -0.48%     
==========================================
  Files          42       46       +4     
  Lines        2001     2092      +91     
  Branches      516      521       +5     
==========================================
+ Hits          990     1025      +35     
- Misses        693      745      +52     
- Partials      318      322       +4     
Impacted Files Coverage Δ
homestar-core/src/lib.rs 100.00% <ø> (ø)
homestar-core/src/workflow/ability.rs 80.00% <ø> (ø)
homestar-core/src/workflow/config.rs 60.52% <ø> (ø)
homestar-core/src/workflow/invocation.rs 65.21% <0.00%> (ø)
homestar-core/src/workflow/issuer.rs 0.00% <ø> (ø)
homestar-core/src/workflow/nonce.rs 31.03% <0.00%> (-2.30%) ⬇️
homestar-core/src/workflow/prf.rs 53.84% <ø> (ø)
homestar-runtime/src/lib.rs 100.00% <ø> (ø)
homestar-runtime/src/main.rs 4.34% <ø> (ø)
homestar-runtime/src/worker.rs 43.90% <0.00%> (-0.88%) ⬇️
... and 21 more

@zeeshanlakhani zeeshanlakhani merged commit 1635ffa into main Jun 14, 2023
10 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/thiserror+workflow-receipts branch June 14, 2023 09:45
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less Anyhow, More ThisError for library crates
1 participant