Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: worker tests, cargo nextest, and better handle on workflow progress #137

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

Includes:

  • foregin_key relationships and join table for many to many workflow(s) to receipts(s)
  • make progress defined by receipts (as Cids) completed
  • handling of db, fallback to libp2p for workflow information and progress
  • tests, tests, tests

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner June 8, 2023 03:33
…progress

Includes:

* foregin_key relationships and join table for many to many workflow(s) to receipts(s)
* make `progress` defined by receipts (as Cids) completed
* handling of db, fallback to libp2p for workflow information and progress
* tests, tests, tests
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #137 (ce9dbaf) into main (f6c5671) will increase coverage by 1.71%.
The diff coverage is 49.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   47.76%   49.47%   +1.71%     
==========================================
  Files          41       42       +1     
  Lines        1721     2001     +280     
  Branches      421      516      +95     
==========================================
+ Hits          822      990     +168     
- Misses        638      693      +55     
- Partials      261      318      +57     
Impacted Files Coverage Δ
homestar-runtime/src/lib.rs 100.00% <ø> (ø)
homestar-runtime/src/main.rs 4.34% <0.00%> (ø)
homestar-runtime/src/settings.rs 71.42% <ø> (ø)
homestar-runtime/src/network/eventloop.rs 3.40% <7.69%> (+1.12%) ⬆️
homestar-runtime/src/db/schema.rs 20.00% <33.33%> (+8.88%) ⬆️
homestar-runtime/src/receipt.rs 49.60% <40.00%> (+0.81%) ⬆️
homestar-runtime/src/scheduler.rs 70.83% <50.00%> (ø)
homestar-runtime/src/worker.rs 44.77% <50.79%> (+44.77%) ⬆️
homestar-runtime/src/db.rs 38.88% <56.00%> (+16.30%) ⬆️
homestar-runtime/src/workflow/info.rs 64.81% <64.81%> (ø)
... and 6 more

... and 6 files with indirect coverage changes

@zeeshanlakhani zeeshanlakhani merged commit ec5dd3a into main Jun 8, 2023
10 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/worker-tests-and-progress branch June 8, 2023 04:02
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant