Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: first run-up of docker for runtime #135

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented May 30, 2023

Provide a docker container for homestar (first run), plus other refactoring around builds.

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner May 30, 2023 20:53
@zeeshanlakhani zeeshanlakhani force-pushed the zl/docker-1 branch 2 times, most recently from a8753fe to f7171f5 Compare May 31, 2023 22:11
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #135 (6ceee93) into main (55ddb91) will decrease coverage by 0.14%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   47.89%   47.76%   -0.14%     
==========================================
  Files          40       41       +1     
  Lines        1712     1721       +9     
  Branches      415      421       +6     
==========================================
+ Hits          820      822       +2     
  Misses        638      638              
- Partials      254      261       +7     
Impacted Files Coverage Δ
homestar-core/src/workflow/issuer.rs 0.00% <0.00%> (ø)
homestar-core/src/workflow/instruction_result.rs 43.75% <50.00%> (ø)
homestar-core/src/workflow/pointer.rs 59.32% <50.00%> (ø)
homestar-core/src/workflow/prf.rs 53.84% <50.00%> (ø)
homestar-runtime/src/receipt.rs 48.78% <50.00%> (ø)

... and 3 files with indirect coverage changes

@zeeshanlakhani zeeshanlakhani merged commit 725a863 into main Jun 1, 2023
10 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/docker-1 branch June 1, 2023 00:26
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant