fix: remove unnecessary decode

ipvm-wg · Nov 16, 2023 · 51ff595 · 51ff595
1 parent cca7581
commit 51ff595
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 31 deletions.
diff --git a/homestar-runtime/tests/fixtures/test-workflow-jco.json b/homestar-runtime/tests/fixtures/test-workflow-jco.json
@@ -1,24 +1,21 @@
 {
-  "name": "componentize",
-  "workflow": {
-    "tasks": [
-      {
-        "cause": null,
-        "meta": {
-          "memory": 4294967296,
-          "time": 100000
-        },
-        "prf": [],
-        "run": {
-          "input": {
-            "args": ["hello", 10],
-            "func": "sum"
-          },
-          "nnc": "",
-          "op": "wasm/run",
-          "rsc": "ipfs://"
-        }
+  "tasks": [
+    {
+      "cause": null,
+      "meta": {
+      "memory": 4294967296,
+      "time": 100000
+    },
+    "prf": [],
+    "run": {
+      "input": {
+        "args": ["hello", 10],
+        "func": "sum"
+      },
+      "nnc": "",
+      "op": "wasm/run",
+      "rsc": "ipfs://bafybeibawnb3pytqmky4ph37hj7y7qosqcneofjextqq55zhxfniiletfu"
       }
-    ]
-  }
+    }
+  ]
 }
diff --git a/homestar-wasm/src/wasmtime/ipld.rs b/homestar-wasm/src/wasmtime/ipld.rs
@@ -12,11 +12,7 @@ use crate::error::{InterpreterError, TagsError};
 use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut};
 use itertools::{FoldWhile::Done, Itertools};
 use libipld::{
-    cid::{
-        self,
-        multibase::{self, Base},
-        Cid,
-    },
+    cid::{self, multibase::Base, Cid},
     Ipld,
 };
 use rust_decimal::{
@@ -345,9 +341,6 @@ impl TryFrom<RuntimeVal> for Ipld {
     type Error = InterpreterError;
 
     fn try_from(val: RuntimeVal) -> Result<Self, Self::Error> {
-        fn base_64_bytes(s: &str) -> Result<Vec<u8>, multibase::Error> {
-            Base::Base64.decode(s)
-        }
         fn cid(s: &str) -> Result<Cid, cid::Error> {
             Cid::try_from(s)
         }
@@ -360,8 +353,6 @@ impl TryFrom<RuntimeVal> for Ipld {
                     s => {
                         if let Ok(cid) = cid(&s) {
                             Ipld::Link(cid)
-                        } else if let Ok(decoded) = base_64_bytes(&s) {
-                            Ipld::Bytes(decoded)
                         } else {
                             Ipld::String(s)
                         }