Fix: from_reader() multibyte varint parsing#80
Open
sumanjeet0012 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Description
This PR fixes an issue where
from_reader()incorrectly parsed CIDv1 when dealing with multihash types or lengths that use multi-byte varints (e.g.,blake2b-256which has the code0xB220).Previously, the parsing logic assumed that the multihash code and digest length were always precisely 1 byte, leading to
ValueError: Not enough data to read CIDv1 multihashwhen decoding multi-byte codes.Changes
varintto correctly decode varint integers incrementally from the stream.varint.decode_streamby implementing an internalTrackingReaderthat properly counts bytes consumed.