Skip to content

Fix: Change default encoding of CIDv1 to base32 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumanjeet0012 wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −3
Open

Fix: Change default encoding of CIDv1 to base32 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf74241
Change default encoding of CIDv1 to base32
sumanjeet0012 Jul 12, 2026
e7bbd13
added newsfragment
sumanjeet0012 Jul 12, 2026
5cfd678
Merge branch 'master' into fix-66-default-base32
sumanjeet0012 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cid/cid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def buffer(self) -> bytes:
"""
return b"".join([bytes([self.version]), multicodec.add_prefix(self.codec, self.multihash)])

def encode(self, encoding: str | None = "base58btc") -> bytes:
def encode(self, encoding: str | None = "base32") -> bytes:
"""
Encoded version of the raw representation

Expand Down
1 change: 1 addition & 0 deletions newsfragments/66.breaking.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Change CIDv1.encode() default encoding to base32 to conform with CID specification.
4 changes: 2 additions & 2 deletions tests/test_cid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ def test_buffer(self, cid):
assert buffer[1:] == multicodec.add_prefix(self.TEST_CODEC, cid.multihash)

def test_encode_default(self, cid):
"""#encode defaults to base58btc encoding"""
assert cid.encode() == b"zdj7WhuEjrB52m1BisYCtmjH1hSKa7yZ3jEZ9JcXaFRD51wVz"
"""#encode defaults to base32 encoding"""
assert cid.encode() == b"bafybeifzjut3te2nhyekklss27nh3k72ysco7y32koao5eei66wof36n5e"

@pytest.mark.parametrize("codec", ENCODINGS)
def test_encode_encoding(self, cid, codec):
Expand Down
Loading