Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function _setDNSCache._getaddrinfo refactored with the following changes:

• Hoist repeated code outside conditional statement (hoist-statement-from-if)
• Swap if/else to remove empty if body (remove-pass-body)

[sourcery-ai]

Function DoubanMovieSpiderMiddleware.process_spider_output refactored with the following changes:

• Replace yield inside for loop with yield from (yield-from)

[sourcery-ai]

Function DoubanMovieSpiderMiddleware.process_start_requests refactored with the following changes:

• Replace yield inside for loop with yield from (yield-from)

[sourcery-ai]

Function Command.run refactored with the following changes:

• Replace multiple comparisons of same variable with in operator (merge-comparisons)

[sourcery-ai]

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.06 out of 10.

	Before	After	Change
Quality	9.31	9.36	0.06
Complexity	1.0	0.71	-0.29
Method Length	24.09	23.04	-1.06
Lines	134	130	-4

Changed files	Quality Before	Quality After	Quality Change
douban_movie/douban_movie/dns_cache.py	9.09	9.24	0.15 ⬆️
douban_movie/douban_movie/middlewares.py	9.37	9.42	0.04 ⬆️
douban_movie/douban_movie/commands/crawlallcomment.py	9.32	9.35	0.03 ⬆️

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!