Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Functionland Fula network pinning service #1889

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ehsan6sha
Copy link

Added Functionland Fula network as a pinning service. The corresponding web-ui PR is: ipfs/ipfs-webui#2242

Describe your changes

Added Functionland Fula pinning service and ipfs endpoints.

Files changed

  • .github\styles\Vocab\ipfs-docs-vocab\accept.txt
  • .github\styles\pln-ignore.txt
  • \docs\concepts\persistence.md
  • \docs\how-to\peering-with-content-providers.md
  • \docs\how-to\work-with-pinning-services.md
  • \docs\quickstart\publish.md
  • \docs\quickstart\publish_cli.md

What issue(s) does this address?

Functionland Fula network is a decentralized ipfs pinning service with 900 globally distribute and individually owned nodes that is missing from the documentation as a major player in ipfs ecosystem

Does this update depend on any other PRs?

Web-ui addition of functionland

Checklist before requesting a review

  • Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

Added Functionland Fula network as a pinning service. The corresponding web-ui PR is: ipfs/ipfs-webui#2242
Copy link

welcome bot commented Jun 28, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting.

Some asks inline, but in general this is blocked until users can use the pinning service, as noted in ipfs/ipfs-webui#2242 (comment)

docs/quickstart/publish_cli.md Outdated Show resolved Hide resolved
docs/quickstart/publish_cli.md Outdated Show resolved Hide resolved
docs/quickstart/publish.md Outdated Show resolved Hide resolved
docs/quickstart/publish_cli.md Show resolved Hide resolved
docs/quickstart/publish.md Outdated Show resolved Hide resolved
docs/concepts/usage-ideas-examples.md Outdated Show resolved Hide resolved
@lidel lidel added need/author-input Needs input from the original author status/blocked Unable to be worked further until needs are met labels Jul 3, 2024
@ehsan6sha
Copy link
Author

@lidel Implemented all of the suggestions and also the ipfs/ipfs-webui#2242 is now completed and use-able by end-users

@ehsan6sha
Copy link
Author

Hey. Please let me know if anything else needs modification before being able to merge
Thank you

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsan6sha mind rebasing this PR? we've clean up and deduplicated various pages and some of your changes are in conflict with main branch now 🙏

@ehsan6sha
Copy link
Author

@ehsan6sha mind rebasing this PR? we've clean up and deduplicated various pages and some of your changes are in conflict with main branch now 🙏

rebase done!

@ehsan6sha ehsan6sha requested a review from lidel August 11, 2024 15:27

| Peer ID | Addresses |
| ------- | --------- |
|`12D3KooWEGy1b9QLiQ4kyjk9GhF3vcWj3aQyVzfbuW7JeS1NdWhb`|`/dns4/ipfs.cloud.fx.land/tcp/443/wss`|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsan6sha this address does not seem to work correctly.

kubo is unable to connect to it:

$ ipfs swarm connect /dns4/ipfs.cloud.fx.land/tcp/443/wss/p2p/12D3KooWEGy1b9QLiQ4kyjk9GhF3vcWj3aQyVzfbuW7JeS1NdWhb
Error: connect 12D3KooWEGy1b9QLiQ4kyjk9GhF3vcWj3aQyVzfbuW7JeS1NdWhb failure: failed to dial: failed to dial 12D3KooWEGy1b9QLiQ4kyjk9GhF3vcWj3aQyVzfbuW7JeS1NdWhb: all dials failed
  * [/ip4/15.223.126.226/tcp/443/tls/sni/ipfs.cloud.fx.land/ws] unexpected EOF

fyi got more info with vole:

$ go install github.com/ipfs-shipyard/vole@latest
$ vole libp2p identify /dns4/ipfs.cloud.fx.land/tcp/443/wss/p2p/12D3KooWEGy1b9QLiQ4kyjk9GhF3vcWj3aQyVzfbuW7JeS1NdWhb
panic: failed to dial: failed to dial 12D3KooWEGy1b9QLiQ4kyjk9GhF3vcWj3aQyVzfbuW7JeS1NdWhb: all dials failed
  * [/ip4/15.223.126.226/tcp/443/tls/sni/ipfs.cloud.fx.land/ws] malformed HTTP response "\x13/multistream/1.0.0"

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(/usage-ideas-examples.md no longer exists)

docs/quickstart/publish.md Outdated Show resolved Hide resolved
docs/quickstart/publish_cli.md Outdated Show resolved Hide resolved
usage-ideas-examples.md no longer exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants