This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Added a ResolveFresh function to skip the cache#37
Open
apiarian wants to merge 1 commit intoipfs:masterfrom
Open
Added a ResolveFresh function to skip the cache#37apiarian wants to merge 1 commit intoipfs:masterfrom
apiarian wants to merge 1 commit intoipfs:masterfrom
Conversation
Member
|
@lgierth LGTY? |
Kubuxu
added
status/ready
ghost
reviewed
Oct 5, 2016
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
CI very badly needs fixing -- let me take care of that real quick.
Let me know about my comment, then definitely push your branch once more to trigger a new CI run
| return s.resolve(id, false) | ||
| } | ||
|
|
||
| // ResolveFresh resolves the string provided to an /ipfs/[hash] without looking |
There was a problem hiding this comment.
Do you mean /ipns/[hash] here? Same for the comment above Resolve()
Contributor
Author
There was a problem hiding this comment.
it resolves the thing provided (which may be an ipns or an ipfs thing?) to an ipfs hash
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Oh okay I fixed it to week ago already: #40 -- in that case, simply rebase your branch on master |
apiarian
force-pushed
the
resolve-nocache
branch
from
e74038c to
a0b02dd
Compare
Contributor
Author
|
@lgierth rebased |
Contributor
Author
|
should i try rebasing again? |
apiarian
force-pushed
the
resolve-nocache
branch
from
a0b02dd to
8740b27
Compare
Member
|
This LGTM, cc @lgierth for 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.