New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing problems with http_requests and requests_wrapper #290

Open

c0llab0rat0r wants to merge 3 commits into ipfs-shipyard:master from c0llab0rat0r:fix-requests-wrapper-typing

Contributor

c0llab0rat0r commented Jun 30, 2021

Most remaining issues (after this pr) are due to:

urllib3 not having enough type info
mypy not supporting mixins well (or perhaps we are not using mixins correctly with mypy)

c0llab0rat0r added 3 commits

June 30, 2021 00:52


          Reduce scope of requests imports in requests_wrapper to only what is …

ad18198

…used


          Fix typing errors in http_requests.py; remove unused functions from r…

0159f3b

…equests_wrapper.py; make typing ignores more granular


          Add --non-interactive flag to mypy command

8ae006d

Contributor Author

c0llab0rat0r commented Jun 30, 2021

@ntninja this is ready for review but I don't think it should be merged until after the 0.8.0 release since its somewhat of an invasive refactor.

#289 should go first be merged for 0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet