[WIP] Make serializer interface streaming #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates some ~= matches as I had used them incorrectly: * `~= 2.7` = `>= 2.7, == 2.*` * `>= 2.7.0` = `>= 2.7.0, == 2.7.*` !
AliabbasMerchant
requested changes
Feb 11, 2020
…ods in adapters Previously `.contains()` would always be forwarded, while `.get_all()` would *usually* be emulated using `(await .get()).collect()`. Now both are emulated by default (simplifies writing new adapters) with the option to set some constants on the class to forward them instead.
Previously it was in the command-line switches in `tox.ini` and `mypy_run.py`.
|
@AliabbasMerchant: But it does have tests? (Only commit acd5245 is relevant, the rest is an old version of #19.) |
|
@Alexander255 I overlooked the tests file 🤦♂ |
AliabbasMerchant
approved these changes
Feb 18, 2020
ntninja
changed the title
|
After some consideration I decided to revise the proposed serializer interface to decouple the serializers from the I/O framework and use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4, depends on #19.
Uses the JSON decoder from
py-ipfs-api-client, but may switch toijsonin the future. Thepickleimplementation still reads the entire stream before beginning parsing, but it's more a proof-of concept anyways.