-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add denylist writing functionality #10
Comments
Given the denylist is plaintext and writing is mostly appending lines to a file, is there anything special that you would expect from this functionality? I'm thinking:
|
For my current purposes, I'd just like to have a Although the conversions that you mention were not what I was originally thinking of, they would also be REALLY nice, generating different types of rules given CIDs, domains, etc. I had to do a bit of reverse-engineering and I'm still not 100% sure that what I did is correct (currently testing). If we agree that this belongs here I could make a couple of PRs to add both the write functionality and one or two of the functions, and take it from there. |
How is this different from |
(or just copying the original file). |
As it stands, the NoPFS library only supports reading the denylist format, but doesn't have any support for writing the denylist to a file. While most applications will only be reading the denylist, there are some that will need to write. It would be best to have both functionalities in the same library, to ensure correct round-tripping.
The text was updated successfully, but these errors were encountered: