Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update icon and make this app a pwa #110

Merged
merged 6 commits into from
Feb 4, 2021
Merged

feat: update icon and make this app a pwa #110

merged 6 commits into from
Feb 4, 2021

Conversation

rafaelramalho19
Copy link
Contributor

@rafaelramalho19 rafaelramalho19 commented Feb 4, 2021 •
edited by lidel
Loading

Closes #108

  • Makes this a PWA
  • Add an offline page (what other cases do we want to cover in the service worker? We could cache assets and so what, but it feels not a priority in an online-sharing app)
  • Update manifest icons

TODO in future PRs

  • Add the /upload handler in the pwa share

@rafaelramalho19 rafaelramalho19 requested a review from lidel February 4, 2021 17:34
@rafaelramalho19 rafaelramalho19 self-assigned this Feb 4, 2021
lidel
lidel requested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Works as expected on Android (both Firefox and Brave).
Super nice for quick sharing of files on the run.

Screenshot_20210204-185333.png

public/manifest.json Outdated Show resolved Hide resolved
public/manifest.json Outdated
Comment on lines 21 to 22
"action": "/upload",
"method": "POST",
Copy link
Member

@lidel lidel Feb 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. are we planning to handle POST via Service Worker? I remember issues with non-GETs and SW.
If looking into this takes too much time we can extract it into a separate issue.

Having PWA mode, even without share target is already a win ❤️ 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to test this out, but is hard since JS-IPFS requires https and I have to test with my phone, but will update #106 with news 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the share for now, please approve the rest 🙏

@rafaelramalho19 rafaelramalho19 requested a review from lidel February 4, 2021 20:25
@lidel lidel merged commit 2aaffba into main Feb 4, 2021
@lidel lidel deleted the feat/pwa branch February 4, 2021 21:10
@lidel
Copy link
Member

lidel commented Feb 4, 2021 •
edited
Loading

Thank you @rafaelramalho19 ❤️
All work as expected on Firefox, Brave and default Google Chrome on Android:

lgKBsrO

@lidel
Copy link
Member

lidel commented Feb 4, 2021

FYSA for some reason Chrome does not show this nice seamless topbar.
This does not seem to be an issue on our end, I checked with other PWA (https://airhorner.com) and it has the same cosmetic issue in Chromium 🤷‍♂️

Firefox Chrome
owZK6aq Sqg1ogp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel Awaiting requested review from lidel

Assignees

@rafaelramalho19 rafaelramalho19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PWA mode for mobile use
2 participants
@rafaelramalho19 @lidel