Added support for delete meter configuration #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bharticemk <[email protected]>
bharticemk
requested review from
ffoulkes,
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
ffoulkes
approved these changes
Dec 15, 2023
| @@ -78,6 +78,7 @@ for P4Runtime switches: | |||
| add-meter-config SWITCH MTR_TBL MTR_FLOW add packet mod meter config table entry | |||
| get-packet-mod-meter SWITCH MTR_TBL MTR_FLOW gets packet mod meter table entry | |||
| get-direct-pkt-mod-meter SWITCH MTR_TBL MTR_FLOW gets direct packet mod meter table entry | |||
| del-meter-config SWITCH MTR_TBL MTR_FLOW delete packet mod meter config table entry | |||
There was a problem hiding this comment.
You might want to consider alphabetizing the meter commands
| ce = entity.meter_entry | ||
|
|
||
| if ce is None: | ||
| raise Exception("Cannot find meter_entry field in entity") |
There was a problem hiding this comment.
Wouldn't something like "No meter_entry field in entity" or "Entity does not specify meter_entry field" be more accurate? You're not exactly searching for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.