-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace networking-recipe CI pipeline #320
Conversation
- Replace the P4 Control Plane CI pipeline. The new pipeline uses precompiles copies of the DPDK SDE and stratum dependencies instead of building them from scratch every time, and it moves the job to run the Stratum unit tests to the stratum repository. The net effect is to reduce the run time of the networking-recipe commit check from ~1.2-1.5 hours to ~10-15 minutes. Signed-off-by: Derek G Foster <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! LGTM
#--------------------------------------------------------------------- | ||
# Environment variables | ||
#--------------------------------------------------------------------- | ||
SDE_REPOSITORY: ipdk-io/p4dev.dpdk-sde |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a sandbox name? We should probably not have a name with dev
in it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the name of a specialty repository that's part of the build automation infrastructure.
# Environment variables | ||
#--------------------------------------------------------------------- | ||
SDE_REPOSITORY: ipdk-io/p4dev.dpdk-sde | ||
SDE_TAG: 2023.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this tag come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer to your question may be found here:
I've scheduled a CI Pipeline Review (Teams meeting) for 9:00 am Wednesday to discuss the mechanics of the revised pipeline. I figured a guided tour would be easier than a written explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace the P4 Control Plane CI pipeline. The new pipeline uses precompiled copies of the DPDK SDE and stratum dependencies instead of building them from scratch every time, and it moves the job to run the Stratum unit tests to the stratum repository.
The net effect is to reduce the run time of the networking-recipe commit check from ~1.2-1.5 hours to ~10-15 minutes.