Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace networking-recipe CI pipeline #320

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Replace networking-recipe CI pipeline #320

merged 1 commit into from
Oct 26, 2023

Conversation

ffoulkes
Copy link
Contributor

  • Replace the P4 Control Plane CI pipeline. The new pipeline uses precompiled copies of the DPDK SDE and stratum dependencies instead of building them from scratch every time, and it moves the job to run the Stratum unit tests to the stratum repository.

    The net effect is to reduce the run time of the networking-recipe commit check from ~1.2-1.5 hours to ~10-15 minutes.

- Replace the P4 Control Plane CI pipeline. The new pipeline uses
  precompiles copies of the DPDK SDE and stratum dependencies
  instead of building them from scratch every time, and it moves
  the job to run the Stratum unit tests to the stratum repository.

  The net effect is to reduce the run time of the networking-recipe
  commit check from ~1.2-1.5 hours to ~10-15 minutes.

Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes ffoulkes changed the title Replace CI pipeline Replace networking-recipe CI pipeline Oct 24, 2023
@ffoulkes ffoulkes added the medium effort Moderate effort required label Oct 24, 2023
Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! LGTM

#---------------------------------------------------------------------
# Environment variables
#---------------------------------------------------------------------
SDE_REPOSITORY: ipdk-io/p4dev.dpdk-sde
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a sandbox name? We should probably not have a name with dev in it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name of a specialty repository that's part of the build automation infrastructure.

# Environment variables
#---------------------------------------------------------------------
SDE_REPOSITORY: ipdk-io/p4dev.dpdk-sde
SDE_TAG: 2023.10.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this tag come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer to your question may be found here:

I've scheduled a CI Pipeline Review (Teams meeting) for 9:00 am Wednesday to discuss the mechanics of the revised pipeline. I figured a guided tour would be easier than a written explanation.

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit aef6efc into main Oct 26, 2023
4 checks passed
@ffoulkes ffoulkes deleted the replace-pipeline branch October 26, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium effort Moderate effort required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants