Append SDE pkgconfig folders to PKG_CONFIG_PATH #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check for `pkgconfig` directories in the SDE and append them to PKG_CONFIG_PATH before using pkg-config to find the DPDK module. Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
added
minor effort
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
nupuruttarwar
approved these changes
Oct 20, 2023
To the best of my knowledge, this change only applies to finding pkg-config files that are part of the SDE (i.e., DPDK for the DPDK TDI target). |
- Address a CMake module warning by using `DpdkDriver` as the DPDK package name instead of `DPDK`. - Correct error in xxx_LDFLAGS variable name. Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
force-pushed
the
dpdk-pkg-config-path
branch
from
36d2739 to
b198e54
Compare
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgconfigdirectories in the SDE and append them to PKG_CONFIG_PATH before using pkg-config to find the DPDK module.This should eliminate the need to set PKG_CONFIG_PATH in the environment and allow the build to "just work".