Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update find_program() commands #311

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update find_program() commands #311

merged 1 commit into from
Oct 13, 2023

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Oct 9, 2023

  • Specify NO_CMAKE_FIND_ROOT_PATH when searching for the Protobuf compiler and gRPC plugin. We do this to ensure that we search the host depencies, not the target dependencies, when cross-compiling.

If #306 causes problems with cross-compilation, this PR should fix them.

@ffoulkes ffoulkes added trivial effort Almost no effort required cmake Affects CMake build system labels Oct 9, 2023
@ffoulkes ffoulkes requested review from mgaravin and satish153 October 9, 2023 23:03
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Specify NO_CMAKE_FIND_ROOT_PATH when searching for the Protobuf
  compiler and gRPC plugin. We do this to ensure that we search the
  host depencies, not the target dependencies, when cross-compiling.

Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes ffoulkes merged commit a542e2e into main Oct 13, 2023
4 checks passed
@ffoulkes ffoulkes deleted the no-find-root-path branch October 13, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Affects CMake build system trivial effort Almost no effort required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants