Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have es2k package add sde to search path #310

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Have es2k package add sde to search path #310

merged 1 commit into from
Oct 11, 2023

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Oct 6, 2023 •
edited
Loading

  • Modify FindEs2kDriver to add SDE_INSTALL_DIR to CMAKE_PREFIX_PATH or CMAKE_FIND_ROOT_PATH.

@ffoulkes ffoulkes added trivial effort Almost no effort required cmake Affects CMake build system labels Oct 6, 2023
@ffoulkes ffoulkes requested a review from satish153 October 6, 2023 23:10
@ffoulkes ffoulkes changed the title Have es2k package add itself to search path Have es2k package add sde to search path Oct 6, 2023
satish153
satish153 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@satish153 satish153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nupuruttarwar
nupuruttarwar approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes
Have es2k package add itself to search path
1ebe283 
- Modify FindEs2kDriver to add the SDE_INSTALL_DIR to
  CMAKE_PREFIX_PATH or CMAKE_FIND_ROOT_PATH.

Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes ffoulkes force-pushed the add-es2k-sde-to-path branch from 1473d5e to 1ebe283 Compare October 9, 2023 23:04
@ffoulkes ffoulkes merged commit 4dc151b into main Oct 11, 2023
4 checks passed
@ffoulkes ffoulkes deleted the add-es2k-sde-to-path branch October 11, 2023 01:28
@ffoulkes ffoulkes mentioned this pull request Oct 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satish153 satish153 satish153 approved these changes

@nupuruttarwar nupuruttarwar nupuruttarwar approved these changes

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

@5abeel 5abeel Awaiting requested review from 5abeel 5abeel is a code owner

Assignees
No one assigned
Labels
cmake Affects CMake build system trivial effort Almost no effort required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffoulkes @nupuruttarwar @satish153