Overhaul cmake interface to Tofino SDE #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
ffoulkes
force-pushed
the
tofino-driver
branch
from
14b182e to
f008227
Compare
- Replace the tofino-driver.cmake include file with FindTofinoDriver.cmake, a find-module that allows us to use `find_package(TofinoDriver)` to define namespaced cmake targets for the Tofino SDE. - Define an `add_tofino_target_libraries()` function that provides an abstract interface to set the properties a target needs in order to compile and link with the Tofino SDE. - Update krnlmon submodule reference. Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
force-pushed
the
tofino-driver
branch
from
f008227 to
7ba9aaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the tofino-driver.cmake include file with FindTofinoDriver.cmake, a find-module that allows us to use
find_package(TofinoDriver)to define namespaced cmake targets for the Tofino SDE.Define an
add_tofino_target_libraries()function that provides an abstract interface to set the properties a target needs in order to compile and link with the Tofino SDE.Update krnlmon submodule reference.