Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving notice for the stratum dependencies #304

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Moving notice for the stratum dependencies #304

merged 6 commits into from
Oct 3, 2023

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Sep 30, 2023

Announce our intention to move the Stratum dependencies to their own repository.

Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, rest LGTM

README.md Outdated
@@ -12,6 +12,13 @@ upstreaming.
It moves the P4-specific components of the architecture to a separate
process called `infrap4d`.

## Upcoming changes

The Stratum dependencies will be moving from the `setup` directory to their
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: their 2 times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed. Made a couple of clarifying edits at the same time.

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes ffoulkes merged commit cdd28a5 into main Oct 3, 2023
4 checks passed
@ffoulkes ffoulkes deleted the moving-notice branch October 3, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants