Helper script maintenance #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
|
In case you're wondering why |
make_all.sh ----------- - Rename --config option to --no-build. config-cross-recipe.sh ---------------------- - Swap short and long option names in switch statement to make it clearer that the names are alphabetized by long name. - Address shellcheck issue. make-cross-ovs.sh ----------------- - Divide help text into Paths and Options sections. - Make _DRY_RUN a numeric variable, and rename _JOBS to _NJOBS, for consistency with other helper scripts. Signed-off-by: Derek G Foster <[email protected]>
- The --staging option is still in the experimental stage and should not be advertised. Signed-off-by: Derek G Foster <[email protected]>
make-cross-deps.sh ------------------ - Divide help text into Paths and Options sections. - Implement --no-build option. - Rename _JOBS variable to _NJOBS. make-host-deps.sh ----------------- - Divide help text into Paths and Options sections. - Rename --config option to --no-build. Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
force-pushed
the
helper-scripts
branch
from
c0e5844 to
255ed5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_all.sh
Rename --config option to --no-build.
Remove --staging option from help text. It is experimental and should not be advertised.
config-cross-recipe.sh
Swap short and long option names in switch statement to make it clearer that the names are alphabetized by long name.
Address shellcheck issue.
make-cross-ovs.sh
Divide help text into Paths and Options sections.
Make _DRY_RUN a numeric variable, and rename _JOBS to _NJOBS, for consistency with other helper scripts.
make-cross-deps.sh
Divide help text into Paths and Options sections.
Implement --no-build option.
Rename _JOBS variable to _NJOBS.
make-host-deps.sh
Divide help text into Paths and Options sections.
Rename --config option to --no-build.