-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p4rt performance test application #267
Conversation
Hi @satish153 , any sample command on how to test this performance will be helpful |
Updated the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and submit this initial review now. I still need to review the code itself.
Nuts. I meant to leave a clarifying comment when I closed my review. The issues I'm chiefly concerned about (the "blockers") are the latent bugs:
Plus the compiler warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The user guide needs some work, but that can be taken care of in a later commit.
BTW, you need to do The failed DCO check is because one or more of them are unsigned. No need to try to fix this PR; I'll bypass the requirement at merge time. Please remember to sign your commits in the future. |
Signed-off-by: Derek G Foster <[email protected]>
Change of plans (and Now for Something Completely Different): I've submitted a PR against your PR to bring the user guide in line with current documentation conventions. |
Revise p4rt_perf_test user guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
p4rt_perf_test is a test application designed to assess the performance of a P4Runtime server across various P4 profiles. The application's primary focus is on measuring the time required to program a specified number of entries.
$IPDK_RECIPE/install/bin/p4rt_perf_test -t 1 -o 1 -n 4000000 -p 1
Total num of entries: 4000000
Number of threads: 1
Operation: 1
Test Profile: 1
Thread data - Core: 20 start_index: 0 num_entries: 4000000
count: 4000000
Num of entries added: 4000000
Time taken: 37.4511 seconds
number of entires per second: 106806
Note:
p4rt_perf.cc/h and p4rt_perf_simple_l2_demo.cc/h are new coded. The code in the rest of the files is repurposed from ovs-p4rt module.
Programming with multiple threads doesn't really work as Stratum currently supports 'write' by only the master.