Revise check_clang_format workflow to report all errors #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoulkes
requested review from
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
ffoulkes
force-pushed
the
improve-clang-check
branch
from
dde54a6 to
b5db7f4
Compare
ffoulkes
added
trivial effort
- The checker fails after finding a file with a format error, requiring multiple commits to find all the errors. This CL updates the workflow to process all changed files in a single invocation of clang-format, which should solve the problem. Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
force-pushed
the
improve-clang-check
branch
from
b5db7f4 to
5ded5d7
Compare
ffoulkes
added a commit
that referenced
this pull request
Mar 5, 2024
The clang-format checker fails after finding a file with a format error, requiring multiple commits to find all the errors. This CL updates the workflow to process all changed files in a single invocation, which should solve the problem. Signed-off-by: Derek G Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang-format checker processes changed files one at a time. It fails after processing a file that has format errors, leaving any subsequent files unchecked. This means that it takes multiple commits to find and fix all the errors.
This CL updates the workflow to process all the changed files in a single invocation of clang-format, which should solve the problem.