LACP Mode Support for LAG #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashishkuma
requested review from
ffoulkes,
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
Signed-off-by: root <[email protected]>
ffoulkes
approved these changes
Jan 5, 2024
| * SWITCHLINK_DB_STATUS_ITEM_NOT_FOUND otherwise | ||
| */ | ||
| switchlink_db_status_t switchlink_db_update_lag_member_oper_state( | ||
| switchlink_db_lag_member_info_t* lag_member_info) { |
There was a problem hiding this comment.
Can lag_member_info be a pointer to const?
| switchlink_db_status_t switchlink_db_update_lag_member_oper_state( | ||
| switchlink_db_lag_member_info_t* lag_member_info) { | ||
| krnlmon_assert(lag_member_info != NULL); | ||
| tommy_node* node = tommy_list_head(&switchlink_db_lag_member_obj_list); |
There was a problem hiding this comment.
Can node be a pointer to const?
Signed-off-by: Kumar, Aashish <[email protected]>
n-sandeep
reviewed
Jan 16, 2024
Signed-off-by: root <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the code changes done in krnlmon module to support LAG in LACP mode.