Add support for include-what-you-use #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
added
trivial effort
ffoulkes
requested review from
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
This was referenced Oct 14, 2023
Merged
5abeel
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include-what-you-use is a utility developed at Google that analyzes C and C++ source files, looking for violations of the Include What You Use rule, and recommends fixes for them.
"The main goal of include-what-you-use is to remove superfluous #includes. It does this both by figuring out what #includes are not actually needed for this file (for both .cc and .h files), and replacing #includes with forward-declares when possible."
This CL implements a cmake option that can be used to run include-what-you-use on krnlmon. It requires standalone build support (#56), plus a trivial change to FindDpdkDriver (ipdk-io/networking-recipe#315) in order to analyze krnlmon for DPDK.