Added password masking in Linux terminal #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #97, which reports that passwords entered in the terminal are visible in plaintext when using 7-Zip with
-pon Linux — a serious security concern.While PR #33 also proposes a solution, this submission offers a slightly different approach by directly updating the
GetPassword()function to perform platform-specific echo masking usingtermioson Linux.Summary of Changes:
termiosfor Linux systems, mirroring existing Windows behavior viaGetConsoleMode.std::endl(which causes compatibility issues withCStdOutStream) with'\n'followed byFlush()to prevent build-time errors.Why This Matters:
This change ensures that password input on Linux no longer echoes to the terminal, reducing the risk of shoulder-surfing and inadvertent password leaks — improving both usability and security.
Fixes: #97