Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch from Travis CI to GitHub Actions #63

Merged
merged 5 commits into from
Aug 24, 2023
Merged

ci: Switch from Travis CI to GitHub Actions #63

merged 5 commits into from
Aug 24, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 24, 2023

About

We are leaving Travis CI behind, and will switch to GitHub Actions (GHA) instead. Along the lines, we will switch from Coveralls to Codecov.

Problems

We needed to skip the test_mock_quota_exceeded test case, because it currently fails.

Also use Codecov instead of Coveralls.
@amotl amotl changed the title ci: Switch from Travis to GitHub Actions ci: Switch from Travis CI to GitHub Actions Aug 24, 2023
@amotl amotl requested a review from gsong August 24, 2023 21:59
Comment on lines 18 to 22
# Tests
@pytest.mark.skip(reason="FIXME: Currently fails")
def test_mock_quota_exceeded(all_clients, monkeypatch):
monkeypatch.setattr(all_clients, "__service_url_prefix__", APIARY_URL)
errors = {
Copy link
Member Author

@amotl amotl Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case fails. The reason is:

requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://opsv31.docs.apiary.io//individual-per-hour-exceeded/publication/docdb/biblio

@gsong: Can you do anything about it, or tell me how I would approach that issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created GH-64 and GH-65, to follow up on this correspondingly.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@36651eb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage        ?   97.41%           
=======================================
  Files           ?       18           
  Lines           ?      425           
  Branches        ?        0           
=======================================
  Hits            ?      414           
  Misses          ?       11           
  Partials        ?        0           
Flag Coverage Δ
unittests 97.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@36651eb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage        ?   97.41%           
=======================================
  Files           ?       18           
  Lines           ?      425           
  Branches        ?        0           
=======================================
  Hits            ?      414           
  Misses          ?       11           
  Partials        ?        0           
Flag Coverage Δ
unittests 97.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review August 24, 2023 22:22
@amotl amotl merged commit 16ce346 into main Aug 24, 2023
6 checks passed
@amotl amotl deleted the modernize-ci branch August 24, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants