Bump configuration module to v2 and adds a migration for escrow params #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeCodeurDuDimanche
added
the
merge when green
davepuchyr
reviewed
Dec 13, 2021
x/configuration/types/genesis.go
Outdated
| CertificateCountMax: 3, | ||
| MetadataSizeMax: 86400, | ||
| EscrowCommission: sdk.ZeroDec(), // zero commission at first | ||
| EscrowBroker: "star1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqjewks3", // so the broker is the burn address |
There was a problem hiding this comment.
EscrowBroker should be star1nrnx8mft8mks3l2akduxdjlf8rwqs8r9l36a78; we don't want to have to do a multisig tx to set it to the correct value after the migration. star1nrnx8mft8mks3l2akduxdjlf8rwqs8r9l36a78 is IOV SAS's multisig account.
There was a problem hiding this comment.
Don't we want this address to be the fee collector module address ?
There was a problem hiding this comment.
No, IOV SAS (star1nrnx8mft8mks3l2akduxdjlf8rwqs8r9l36a78) spent time and resources to develop this module. It is fully justified in charging the commission. Once #31 is closed then it does make sense to use the fee collector module address.
davepuchyr
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new consensus version for the
configurationmodule, because it has breaking changes with the addition of the escrow configuration parameters and specific fees.The migration takes the old parameters and fees and adds the new default parameters and fees.
This migration is part of the
cosmos-sdk-v0.44-upgradeupgrade plan