Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

bug fix #259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bug fix #259

wants to merge 3 commits into from

Conversation

WhoAmI233
Copy link

Issue #233
Closes #233

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #259 into master will increase coverage by 0.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   43.50%   43.79%   +0.28%     
==========================================
  Files          20       20              
  Lines        3349     3327      -22     
==========================================
  Hits         1457     1457              
+ Misses       1534     1512      -22     
  Partials      358      358              
Impacted Files Coverage Δ
indexprotocol/rewards/protocol.go 28.79% <0.00%> (-0.37%) ⬇️
queryprotocol/actions/protocol.go 25.55% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7355906...910ff7f. Read the comment docs.

Copy link
Contributor

@coderbradlee coderbradlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1ce448d). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #259   +/-   ##
=========================================
  Coverage          ?   43.79%           
=========================================
  Files             ?       20           
  Lines             ?     3327           
  Branches          ?        0           
=========================================
  Hits              ?     1457           
  Misses            ?     1512           
  Partials          ?      358           
Impacted Files Coverage Δ
indexprotocol/rewards/protocol.go 28.79% <0.00%> (ø)
indexprotocol/votings/candidateoperator.go 63.26% <0.00%> (ø)
indexprotocol/actions/hermes.go 40.57% <0.00%> (ø)
indexprotocol/actions/xrc20.go 59.72% <0.00%> (ø)
indexprotocol/votings/protocol.go 39.16% <0.00%> (ø)
sql/storebase_tests.go 92.72% <0.00%> (ø)
indexprotocol/accounts/protocol.go 45.62% <0.00%> (ø)
sql/rds.go 0.00% <0.00%> (ø)
sql/storebase.go 61.70% <0.00%> (ø)
indexprotocol/votings/probation.go 73.43% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce448d...d8141ed. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If valArgs and valStrs in rebuildAccountReward() is empty, return nil and throw a warning
5 participants