lint fix

.golangci.yml

@@ -145,7 +145,6 @@ linters:
         - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases
         - exportloopref # Checks for pointers to enclosing loop variables.
         - funlen # Tool for detection of long functions.
-        - goconst # Finds repeated strings that could be replaced by a constant.
         - gocritic # Provides many diagnostics that check for bugs, performance and style issues.
         - gocyclo # Computes and checks the cyclomatic complexity of functions.
         - goerr113 # Golang linter to check the errors handling expressions.
@@ -186,6 +185,7 @@ linters:
         - wastedassign # wastedassign finds wasted assignment statements. [fast: true, auto-fix: false]
 
 
+    # - goconst # Finds repeated strings that could be replaced by a constant.
     # - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
     # nlreturn # nlreturn checks for a new line before return and branch statements to increase code clarity [fast: true, auto-fix: false]
     # don't enable:

packages/evm/solidity/abi.go

@@ -42,7 +42,7 @@ func StorageEncodeString(slotNumber uint8, s string) (ret map[common.Hash]common
 	ret[mainSlot] = common.BigToHash(big.NewInt(int64(len(s)*2) + 1))
 
 	i := 0
-	for len(s) > 0 {
+	for s != "" {
 		var chunk common.Hash
 		copy(chunk[:], s)
 

packages/nodeconn/nodeconn.go

@@ -87,7 +87,9 @@ func (nc *nodeConnection) RefreshOnLedgerRequests(ctx context.Context, chainID i
 	if !ok {
 		panic("unexpected chainID")
 	}
-	ncChain.refreshOwnedOutputs(ctx)
+	if err := ncChain.refreshOwnedOutputs(ctx); err != nil {
+		nc.LogError(fmt.Sprintf("error refreshing outputs: %s", err.Error()))
+	}
 }
 
 func New(

packages/trie/test/proof_test.go

@@ -30,7 +30,7 @@ func TestProofScenariosBlake2b(t *testing.T) {
 				p := trr.MerkleProof([]byte(k))
 				err = p.Validate(root.Bytes())
 				require.NoError(t, err)
-				if len(v) > 0 {
+				if v != "" {
 					cID := trie.CommitToData([]byte(v))
 					err = p.ValidateWithTerminal(root.Bytes(), cID.Bytes())
 					require.NoError(t, err)

packages/trie/test/trie_test.go

@@ -299,7 +299,7 @@ func runUpdateScenario(trieUpdatable *trie.TrieUpdatable, store trie.KVStore, sc
 				continue // key must not be empty
 			}
 			key = []byte(before)
-			if len(after) > 0 {
+			if after != "" {
 				value = []byte(after)
 			}
 		} else {
@@ -333,11 +333,11 @@ func checkResult(t *testing.T, trie *trie.TrieUpdatable, checklist map[string]st
 	for key, expectedValue := range checklist {
 		v := trie.GetStr(key)
 		if traceScenarios {
-			if len(v) > 0 {
+			if v != "" {
 				fmt.Printf("FOUND '%s': '%s' (expected '%s')\n", key, v, expectedValue)
 			} else {
 				fmt.Printf("NOT FOUND '%s' (expected '%s')\n", key, func() string {
-					if len(expectedValue) > 0 {
+					if expectedValue != "" {
 						return "FOUND"
 					}
 					return "NOT FOUND"

packages/trie/trie_kvstore.go

@@ -202,7 +202,7 @@ func (tr *TrieUpdatable) delete(triePath []byte) {
 			nodes[i-1].removeChild(nil, idxAsChild)
 		}
 	}
-	assertf(nodes[0] != nil, "please do not delete root") //nolint:gosec // false positive
+	assertf(nodes[0] != nil, "please do not delete root")
 }
 
 func (tr *TrieUpdatable) mergeNodeIfNeeded(node *bufferedNode) *bufferedNode {

packages/util/pipe/queue_test.go

@@ -170,12 +170,11 @@ func TestLimitPriorityLimitedPriorityHashQueueTwice(t *testing.T) {
 				return 3*index/2 - 20
 			}
 			return (3*index - 41) / 2
-		} else {
-			if index%2 == 1 {
-				return (3*index - 139) / 2
-			}
-			return 3*index/2 - 70
 		}
+		if index%2 == 1 {
+			return (3*index - 139) / 2
+		}
+		return 3*index/2 - 70
 	}
 	testQueueTwice(NewSimpleNothashableFactory(), q, elementsToAddSingle, alwaysTrueFun, limit, resultFun, t)
 }
@@ -262,12 +261,11 @@ func testPriorityQueueTwice[E IntConvertible](factory Factory[E], makePriorityQu
 				return 3*index/2 - 50
 			}
 			return (3*index - 101) / 2
-		} else {
-			if index%2 == 1 {
-				return (3*index - 199) / 2
-			}
-			return 3*index/2 - 100
 		}
+		if index%2 == 1 {
+			return (3*index - 199) / 2
+		}
+		return 3*index/2 - 100
 	}
 	testQueueTwice(factory, q, elementsToAddSingle, alwaysTrueFun, 2*elementsToAddSingle, resultFun, t)
 }
@@ -354,12 +352,11 @@ func TestLimitPriorityHashLimitedPriorityHashQueueDuplicates(t *testing.T) {
 				return 3*index - 40
 			}
 			return 3*index - 41
-		} else {
-			if index%2 == 0 {
-				return 3*index - 139
-			}
-			return 3*index - 140
 		}
+		if index%2 == 0 {
+			return 3*index - 139
+		}
+		return 3*index - 140
 	}
 	testQueueBasicAddLengthPeekRemove(NewSimpleHashableFactory(), q, 3*elementsToAddFirstIteration, addFun, addResultFun, limit, resultFun, t)
 }

packages/vm/core/governance/governanceimpl/chaininfo.go

@@ -19,7 +19,7 @@ func getChainInfo(ctx isc.SandboxView) dict.Dict {
 	ret.Set(governance.VarGasFeePolicyBytes, info.GasFeePolicy.Bytes())
 	ret.Set(governance.VarGasLimitsBytes, info.GasLimits.Bytes())
 
-	if len(info.PublicURL) > 0 {
+	if info.PublicURL != "" {
 		ret.Set(governance.VarPublicURL, codec.EncodeString(info.PublicURL))
 	}
 

packages/webapi/controllers/chain/waitforrequest.go

@@ -32,7 +32,7 @@ func (c *Controller) waitForRequestToFinish(e echo.Context) error {
 	timeout := defaultTimeoutSeconds * time.Second
 
 	timeoutInSeconds := e.QueryParam("timeoutSeconds")
-	if len(timeoutInSeconds) > 0 {
+	if timeoutInSeconds != "" {
 		parsedTimeout, _ := strconv.Atoi(timeoutInSeconds)
 
 		if err != nil {

tools/schema/model/yaml/convert.go

@@ -85,10 +85,10 @@ func (n *Node) toStringElt() model.DefElt {
 
 func (n *Node) toDefElt() *model.DefElt {
 	comment := ""
-	if len(n.HeadComment) > 0 {
+	if n.HeadComment != "" {
 		// remove trailing '\n' and space
 		comment = strings.TrimSpace(n.HeadComment)
-	} else if len(n.LineComment) > 0 {
+	} else if n.LineComment != "" {
 		// remove trailing '\n' and space
 		comment = strings.TrimSpace(n.LineComment)
 	}
@@ -126,9 +126,9 @@ func (n *Node) toDefMapMap() model.DefMapMap {
 			continue
 		}
 		comment := ""
-		if len(yamlKey.HeadComment) > 0 {
+		if yamlKey.HeadComment != "" {
 			comment = strings.TrimSpace(yamlKey.HeadComment) // remove trailing '\n'
-		} else if len(yamlKey.LineComment) > 0 {
+		} else if yamlKey.LineComment != "" {
 			comment = strings.TrimSpace(yamlKey.LineComment) // remove trailing '\n'
 		}
 
@@ -146,9 +146,9 @@ func (n *Node) toDefMapMap() model.DefMapMap {
 func (n *Node) toFuncDef() model.FuncDef {
 	def := model.FuncDef{}
 	def.Line = n.Line
-	if len(n.HeadComment) > 0 {
+	if n.HeadComment != "" {
 		def.Comment = strings.TrimSpace(n.HeadComment) // remove trailing '\n'
-	} else if len(n.LineComment) > 0 {
+	} else if n.LineComment != "" {
 		def.Comment = strings.TrimSpace(n.LineComment) // remove trailing '\n'
 	}
 
@@ -164,9 +164,9 @@ func (n *Node) toFuncDef() model.FuncDef {
 				return model.FuncDef{}
 			}
 			def.Access = *yamlKey.Contents[0].toDefElt()
-			if len(yamlKey.HeadComment) > 0 {
+			if yamlKey.HeadComment != "" {
 				def.Access.Comment = strings.TrimSpace(yamlKey.HeadComment) // remove trailing '\n'
-			} else if len(yamlKey.LineComment) > 0 {
+			} else if yamlKey.LineComment != "" {
 				def.Access.Comment = strings.TrimSpace(yamlKey.LineComment) // remove trailing '\n'
 			}
 		case KeyParams:
@@ -188,9 +188,9 @@ func (n *Node) toFuncDefMap() model.FuncDefMap {
 			continue
 		}
 		comment := ""
-		if len(yamlKey.HeadComment) > 0 {
+		if yamlKey.HeadComment != "" {
 			comment = strings.TrimSpace(yamlKey.HeadComment) // remove trailing '\n'
-		} else if len(yamlKey.LineComment) > 0 {
+		} else if yamlKey.LineComment != "" {
 			comment = strings.TrimSpace(yamlKey.LineComment) // remove trailing '\n'
 		}
 		key := model.DefElt{