feat: Use error text instead of text code #421
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoe
reviewed
Dec 8, 2024
| // The allowance coin_types vector and balances vector are not in the same size | ||
| const EAllowanceVecUnequal: u64 = 0; | ||
| #[error] | ||
| const EAllowanceVecUnequal: vector<u8> = b"The allowance's coin_types and balances vector are not in the same size"; |
There was a problem hiding this comment.
Do error messages get persisted - i.e do they have a byte cost?
howjmay
force-pushed
the
improve-move-err-msg
branch
from
21c84ba to
bf2b8c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://move-book.com/move-basics/assert-and-abort.html for more details