Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin derange version to avoid conflicts in iota-sdk on alpha branch #1623

Conversation

wulfraem
Copy link
Contributor

Description of change

Pin dependency derange depdendency of time and limit range, as 0.4.1 has impl for usize: PartialOrd<_>, that conflicts with iota-sdks core impl, leading to errors in iota-sdk crate during build.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tested build locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
* pin `derange` version to avoid conflicts in `iota-sdk`

* bump `actions/cache@` version
…ota-sdk-on-alpha
@wulfraem wulfraem added Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Mar 26, 2025
@wulfraem wulfraem requested a review from a team as a code owner March 26, 2025 07:33
@UMR1352 UMR1352 requested a review from a team March 26, 2025 13:15
@wulfraem wulfraem merged commit 2b0bf00 into feat/identity-rebased-alpha Apr 2, 2025
16 checks passed
@wulfraem wulfraem deleted the fix/pin-derange-version-to-fix-conflict-in-iota-sdk-on-alpha branch April 2, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants