Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement into ecdsa, identity handle, send job #12

Merged
merged 11 commits into from
Apr 28, 2024
Merged

implement into ecdsa, identity handle, send job #12

merged 11 commits into from
Apr 28, 2024

Conversation

rkdud007
Copy link
Collaborator

No description provided.

@Okm165
Copy link
Contributor

Okm165 commented Apr 26, 2024

I removed Identity handler pls take a look and wdyt about current solution?

@Okm165 Okm165 marked this pull request as ready for review April 26, 2024 17:48
@Okm165 Okm165 self-assigned this Apr 26, 2024
@Okm165 Okm165 self-requested a review April 26, 2024 17:48
@Okm165 Okm165 removed their assignment Apr 26, 2024
@rkdud007
Copy link
Collaborator Author

rkdud007 commented Apr 27, 2024

The reason why introduced identity is, each node have 2 type of identity.

  1. p2p network identity 2) it's connected personal crypto account ( in first ver its starknet account. )

I checked you introduced below instead of identity,

let p2p_local_keypair = libp2p::identity::Keypair::generate_ecdsa();

which this Keypair generates secrete key & public key which is not tied to crypto account anymore.

would suggest to have identity back, and I wanted to push this identity flow :

  1. user specify keystore file path
  2. identityhandler get keystore and generate 1) p2p identity 2) starknet identity ( connect )
  3. and we can use this abstracted identity handler in both p2p context and starknet context.

so that user ( who decided to become delegator ) only need to care about preparing keystore for their starknet account

Copy link
Contributor

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM GJ!

@rkdud007 rkdud007 merged commit c57b6f3 into main Apr 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants