Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provision-with-micromamba is deprecated #102

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 26, 2023

Using mamba-org/setup-micromamba@v1 instead.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 29, 2023

All the tests that use numba and masked arrays are failing. In a way, they were probably wrong before even when they passed b/c numba doesn't support masked arrays. xref.: numba/numba#1834

Ideally we should fix the tests but we can pin to numba<0.57 to restore the old behavior.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 29, 2023

@kwilcox I'm not sure pinning to an old numba is the best course of action here. What do you think? I would just fail,for now, when masked array are used with numba, until numba supports them properly.

@ocefpaf ocefpaf requested a review from kwilcox May 29, 2023 12:41
@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 14, 2024

@srstsavage and @kthyng I'm self-merging this one to move things forward. Note that we have a pin on numba that limits ioos_qc use with Python >=3.11. I'll investigate that but for now we should issue a new release to prevent folks from installing it with an unpinned numba.

PS: I also fixed some tz-aware date comparisons by making all the tests tz-naive. We should add specific tz-aware tests though in the future.

@ocefpaf ocefpaf merged commit daba0ee into ioos:main Mar 14, 2024
9 checks passed
@ocefpaf ocefpaf deleted the update_umamba_GHA branch March 14, 2024 19:12
@srstsavage
Copy link

@ocefpaf 👍 thank you!

@ocefpaf ocefpaf mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants