Skip to content

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented May 6, 2024

No description provided.

Comment on lines +2 to +18
"name": "F# (.NET 7.0)",
"dockerFile": "Dockerfile",
"customizations": {
"vscode": {
"settings": {
"terminal.integrated.shell.linux": "/bin/bash",
"FSharp.useSdkScripts": true,
"FSharp.workspacePath": "FsAutoComplete.sln"
},
"extensions": [
"Ionide.Ionide-fsharp",
"ms-vscode.csharp"
]
}
},
"onCreateCommand": "dotnet restore"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this because it referenced paket, but also because the json schema linting warnings said that the old format was incorrect.

Comment on lines +166 to +169
"[msbuild]": {
"editor.formatOnSave": false
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my extensions have been formatting project files - no more!

Comment on lines +13 to +16
<!-- <packageSource key="dotnet8">
<package pattern="FSharp.Core" />
<package pattern="FSharp.Compiler.Service" />
</packageSource> -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on nightly, we can just uncomment this mapping and update/outdated/etc commands will just work for these two packages. we can run dotnet list package --outdated and see what the updateable versions are

///
/// Note: As constant, because F# doesn't have `#define`
[<Literal>]
let private DEBUG = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was building with a 9 preview SDK and the inlining/visibility changes that Kevin made flagged a bunch of failed inlining in this file.

@baronfel baronfel force-pushed the packagereference branch from d5b501c to 61f57c0 Compare May 6, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant