Skip to content

Commit

Permalink
Merge pull request #212 from Sandipkakadiya/review
Browse files Browse the repository at this point in the history
Review & Release
  • Loading branch information
Sandipkakadiya authored Nov 24, 2020
2 parents 47e2a3b + 8ae4ee5 commit 9bceb78
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 9 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ before_script:
script:
- ./../flutter/bin/flutter analyze .
- ./../flutter/bin/cache/dart-sdk/bin/dartfmt --dry-run lib
- ./../flutter/bin/flutter test
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog


## 1.2.3 - 2020-11-12
## 1.2.4 - 2020-11-12

### Fixed
* [GFProgressBar] issue.
Expand All @@ -11,6 +11,11 @@
* [GFCarousel] issue. #185
* Many more minor improvements.

### Added
* Test cases added for couple of components
- GFLoader
- GFTypography



## 1.2.2 - 2020-10-02
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ packages:
path: ".."
relative: true
source: path
version: "1.2.3"
version: "1.2.4"
matcher:
dependency: transitive
description:
Expand Down
4 changes: 3 additions & 1 deletion lib/components/appbar/gf_appbar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,9 @@ class _GFAppBarState extends State<GFAppBar> {
assert(debugCheckHasMaterialLocalizations(context));
final ThemeData theme = Theme.of(context);
final AppBarTheme appBarTheme = AppBarTheme.of(context);
final ScaffoldState scaffold = Scaffold.of(context, nullOk: true);
final ScaffoldState scaffold = Scaffold.of(context);
// final ScaffoldState scaffold =Scaffold.of(context, nullOk: true);
// final ScaffoldState scaffold = Scaffold.maybeOf(context);
final ModalRoute<dynamic> parentRoute = ModalRoute.of(context);
final bool hasDrawer = scaffold?.hasDrawer ?? false;
final bool hasEndDrawer = scaffold?.hasEndDrawer ?? false;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: getwidget
description: GetWidget is open source libraries that come with pre-build 1000+ UI components. It makes development faster & more enjoyable. You can customize the component as per your need.
version: 1.2.3
version: 1.2.4
homepage: https://github.com/ionicfirebaseapp/getwidget

environment:
Expand Down
5 changes: 0 additions & 5 deletions test/getflutter_test.dart

This file was deleted.

0 comments on commit 9bceb78

Please sign in to comment.