Merge pull request #193 from Sandipkakadiya/review

Review
ionicfirebaseapp · Oct 2, 2020 · 1b62a84 · 1b62a84
2 parents 1c5732e + 3196e04
commit 1b62a84
Show file tree

Hide file tree

Showing 51 changed files with 844 additions and 1,632 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,26 @@
 # Changelog
 
+
+## 1.2.2 - 2020-10-02
+
+### Fixed
+* [GFButton] width related issue.
+* [GFRadio] minor issue.
+* [GFRadioListTile] selection issue
+* [GFCheckbox] minor issue.
+* [GFCheckboxListTile] selection issue
+* Many more minor improvements.
+
+### Added
+* few new compoenents added
+    - GFBottomSheet
+    - GFIntroScreen
+    - GFAnimation
+    - GFBorder
+    - GFStickyHeader
+
+
+
 ## 1.1.3 - 2020-07-30
 
 ### Fixed
@@ -9,7 +30,7 @@
 * [GFCarousel] active page indicator is not being updated without "onPageChanged" #139
 * [GFTabBar] Docs say about isScrollable which is not supported #132
 
-### Update
+### Added
 * couple of compoenents (WIP)
     - GFCheckboxTile
     - GFRadioTile

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -7,42 +7,42 @@ packages:
       name: async
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.4.2"
+    version: "2.5.0-nullsafety.1"
   boolean_selector:
     dependency: transitive
     description:
       name: boolean_selector
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.0"
+    version: "2.1.0-nullsafety.1"
   characters:
     dependency: transitive
     description:
       name: characters
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.0"
+    version: "1.1.0-nullsafety.3"
   charcode:
     dependency: transitive
     description:
       name: charcode
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.3"
+    version: "1.2.0-nullsafety.1"
   clock:
     dependency: transitive
     description:
       name: clock
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.1"
+    version: "1.1.0-nullsafety.1"
   collection:
     dependency: transitive
     description:
       name: collection
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.14.13"
+    version: "1.15.0-nullsafety.3"
   convert:
     dependency: transitive
     description:
@@ -63,7 +63,7 @@ packages:
       name: fake_async
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.0"
+    version: "1.2.0-nullsafety.1"
   flutter:
     dependency: "direct main"
     description: flutter
@@ -92,28 +92,28 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.1.3"
+    version: "1.2.2"
   matcher:
     dependency: transitive
     description:
       name: matcher
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.12.8"
+    version: "0.12.10-nullsafety.1"
   meta:
     dependency: transitive
     description:
       name: meta
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.8"
+    version: "1.3.0-nullsafety.3"
   path:
     dependency: transitive
     description:
       name: path
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.7.0"
+    version: "1.8.0-nullsafety.1"
   path_drawing:
     dependency: transitive
     description:
@@ -148,7 +148,7 @@ packages:
       name: plugin_platform_interface
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.2"
+    version: "1.0.1"
   pub_semver:
     dependency: transitive
     description:
@@ -167,49 +167,49 @@ packages:
       name: source_span
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.7.0"
+    version: "1.8.0-nullsafety.2"
   stack_trace:
     dependency: transitive
     description:
       name: stack_trace
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.9.5"
+    version: "1.10.0-nullsafety.1"
   stream_channel:
     dependency: transitive
     description:
       name: stream_channel
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.0"
+    version: "2.1.0-nullsafety.1"
   string_scanner:
     dependency: transitive
     description:
       name: string_scanner
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.5"
+    version: "1.1.0-nullsafety.1"
   term_glyph:
     dependency: transitive
     description:
       name: term_glyph
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.0"
+    version: "1.2.0-nullsafety.1"
   test_api:
     dependency: transitive
     description:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.2.17"
+    version: "0.2.19-nullsafety.2"
   typed_data:
     dependency: transitive
     description:
       name: typed_data
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.2.0"
+    version: "1.3.0-nullsafety.3"
   url_launcher:
     dependency: "direct main"
     description:
@@ -251,7 +251,7 @@ packages:
       name: vector_math
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.8"
+    version: "2.1.0-nullsafety.3"
   xml:
     dependency: transitive
     description:
@@ -260,5 +260,5 @@ packages:
     source: hosted
     version: "4.2.0"
 sdks:
-  dart: ">=2.9.0-14.0.dev <3.0.0"
-  flutter: ">=1.18.0-6.0.pre <2.0.0"
+  dart: ">=2.10.0-110 <2.11.0"
+  flutter: ">=1.18.0-6.0.pre <2.0.0"
diff --git a/lib/components/accordian/gf_accordian.dart b/lib/components/accordian/gf_accordian.dart
@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:getwidget/getwidget.dart';
 
 class GFAccordion extends StatefulWidget {
+  /// An accordion is used to show (and hide) content. Use [showAccordion] to hide & show the accordion content.
   const GFAccordion(
       {Key key,
       this.titleChild,

diff --git a/lib/components/animation/gf_animation.dart b/lib/components/animation/gf_animation.dart
@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:getwidget/types/gf_animation_type.dart';
 
 class GFAnimation extends StatefulWidget {
+  /// Wrap any widget with [GFAnimation] to animate your widget. see [GFAnimationType] for types of animations.
   const GFAnimation({
     Key key,
     this.duration,

diff --git a/lib/components/badge/gf_button_badge.dart b/lib/components/badge/gf_button_badge.dart
@@ -272,53 +272,3 @@ class _GFButtonBadgeState extends State<GFButtonBadge> {
         ),
       );
 }
-
-//
-//class GFButtonBadge extends GFButton {
-//
-//
-//  Widget build(BuildContext context) => ConstrainedBox(
-//        constraints: const BoxConstraints(
-//          minHeight: 26,
-//          minWidth: 98,
-//        ),
-//        child: Container(
-//          height: size,
-//          child: GFButton(
-//            onPressed: onPressed,
-//            onHighlightChanged: onHighlightChanged,
-//            textStyle: textStyle,
-//            boxShadow: boxShadow,
-//            buttonBoxShadow: badgeBoxShadow,
-//            focusColor: focusColor,
-//            hoverColor: hoverColor,
-//            highlightColor: highlightColor,
-//            splashColor: splashColor,
-//            elevation: elevation,
-//            focusElevation: focusElevation,
-//            hoverElevation: hoverElevation,
-//            highlightElevation: highlightElevation,
-//            disabledElevation: disabledElevation,
-//            constraints: constraints,
-//            borderShape: borderShape,
-//            animationDuration: animationDuration,
-//            clipBehavior: clipBehavior,
-//            focusNode: focusNode,
-//            autofocus: autofocus,
-//            type: type,
-//            shape: shape,
-//            color: color,
-//            textColor: textColor,
-//            position: position,
-//            size: size,
-//            borderSide: borderSide,
-//            text: text,
-//            icon: icon,
-//            blockButton: blockButton,
-//            fullWidthButton: fullWidthButton,
-//            disabledColor: disabledTextColor,
-//            disabledTextColor: disabledColor,
-//          ),
-//        ),
-//      );
-//}
diff --git a/lib/components/badge/gf_icon_badge.dart b/lib/components/badge/gf_icon_badge.dart
@@ -34,9 +34,6 @@ class _GFIconBadgeState extends State<GFIconBadge> {
           children: <Widget>[
             widget.child ?? Container(),
             Positioned(
-              //  top: 2,
-              //  left: 22,
-              right: 0,
               child: widget.counterChild ?? Container(),
             ),
           ],

diff --git a/lib/components/border/gf_border.dart b/lib/components/border/gf_border.dart
@@ -5,11 +5,12 @@ import 'package:getwidget/components/border/gf_dashed_border.dart';
 import 'package:getwidget/types/gf_border_type.dart';
 
 class GFBorder extends StatelessWidget {
+  /// Create different types of borders around given child widget
   GFBorder({
     @required this.child,
     this.color = Colors.black,
     this.strokeWidth = 1,
-    this.type = GFBorderType.Rect,
+    this.type = GFBorderType.rect,
     this.dashedLine = const <double>[3, 1],
     this.padding = const EdgeInsets.all(10),
     this.radius = const Radius.circular(0),
@@ -27,7 +28,7 @@ class GFBorder extends StatelessWidget {
   final double strokeWidth;
 
   /// color of type [Color] or GFColor which is used to change the color of the border type
-  final dynamic color;
+  final Color color;
 
   /// dashedLine of type [List<double>] which is used for the linear and simple dashed line of border
   final List<double> dashedLine;