fix(react): type overlay hook component props#31183
Open
SSDWGG wants to merge 1 commit into
Open
Conversation
|
@SSDWGG is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28680
What is the current behavior?
useIonModalanduseIonPopoveracceptcomponentPropsasany, so props passed to typed React components are not checked.What is the new behavior?
ReactComponent<Props = any>helper while keepingReactComponentOrElementbackward-compatible.useIonModalanduseIonPopoverso component props are inferred from function/class components.Does this introduce a breaking change?
The generic defaults to
any, and JSX element overloads keep the previous permissive behavior.Testing
npm ciinpackages/reactnpm run test.spec -- --runTestsByPath src/hooks/__tests__/overlay-hook-types.spec.tsxnpx tsc --noEmit --project tsconfig.json --skipLibChecknpx prettier --check src/hooks/useIonModal.ts src/hooks/useIonPopover.ts src/hooks/__tests__/overlay-hook-types.spec.tsx src/models/ReactComponentOrElement.tsnpx eslint src/hooks/useIonModal.ts src/hooks/useIonPopover.ts src/hooks/__tests__/overlay-hook-types.spec.tsx src/models/ReactComponentOrElement.tsNote: plain
npx tsc --noEmit --project tsconfig.jsonis blocked by the existingAbortSignaldeclaration conflict between DOM and@types/node; the same command passes with--skipLibCheck. ESLint exits successfully, with the repository ignore warning forsrc/hooks/__tests__/overlay-hook-types.spec.tsx.