Skip to content

fix(tab-button): dark palette focused background color #31050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnbm wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(tab-button): dark palette focused background color #31050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff6a21b
fix(tab-button): apply correct focused background color in dark palette
gnbm Mar 30, 2026
c6c6ea3
fix(tab-button): fix prettier issues
gnbm Mar 30, 2026
cd5c16c
chore(): add updated snapshots
Ionitron Mar 30, 2026
b5a7d0b
fix(tab-button): apply code review feedback v1
gnbm Mar 31, 2026
585a801
fix(tab-button): update snapshot
gnbm Mar 31, 2026
59d7631
fix(tab-button): apply code review feedback v2
gnbm Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions core/src/components/tab-button/test/states/tab-button.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,25 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c
});
});
});

configs({ palettes: ['dark'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
Copy link
Copy Markdown
Member

@ShaneK ShaneK Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other two blocks in this file nest tests inside test.describe('focus', ...). Should this follow the same pattern? Something like title('tab-button: states in dark palette') with a nested test.describe('focus', ...) inside

test.describe(title('tab-button: states in dark palette'), () => {
test.describe('focus', () => {
test('should render correct focus state in dark palette', async ({ page }) => {
await page.setContent(
`
<ion-tab-bar style="width: 300px">
<ion-tab-button href="#" class="ion-focused">
<ion-label>Favorites</ion-label>
</ion-tab-button>
</ion-tab-bar>
`,
config
);

const tabBar = page.locator('ion-tab-bar');
await expect(tabBar).toHaveScreenshot(screenshot('tab-button-focus'));
});
});
});
});
Binary file added ...b-button.e2e.ts-snapshots/tab-button-focus-ios-ltr-dark-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...-button.e2e.ts-snapshots/tab-button-focus-ios-ltr-dark-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...b-button.e2e.ts-snapshots/tab-button-focus-ios-ltr-dark-Mobile-Safari-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ab-button.e2e.ts-snapshots/tab-button-focus-md-ltr-dark-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...b-button.e2e.ts-snapshots/tab-button-focus-md-ltr-dark-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ab-button.e2e.ts-snapshots/tab-button-focus-md-ltr-dark-Mobile-Safari-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions core/src/css/palettes/dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ $colors: (
--ion-text-color-step-900: #1a1a1a;
--ion-text-color-step-950: #0d0d0d;
--ion-item-background: #000000;
--ion-tab-bar-background-focused: #0b0b0b;
--ion-card-background: #1c1c1d;
}

Expand Down Expand Up @@ -183,6 +184,7 @@ $colors: (
--ion-item-background: #1e1e1e;
--ion-toolbar-background: #1f1f1f;
--ion-tab-bar-background: #1f1f1f;
--ion-tab-bar-background-focused: #1b1b1b;
--ion-card-background: #1e1e1e;
}
}
2 changes: 2 additions & 0 deletions core/src/css/palettes/high-contrast-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ $lightest-text-color: $text-color;
--ion-text-color-rgb: #{color-to-rgb-list($text-color)};
--ion-item-background: #000000;
--ion-card-background: #1c1c1d;
--ion-tab-bar-background-focused: #0b0b0b;

/// Only the item borders should increase in contrast
/// Borders for elements like toolbars should remain the same
Expand Down Expand Up @@ -185,6 +186,7 @@ $lightest-text-color: $text-color;
--ion-item-background: #1e1e1e;
--ion-toolbar-background: #1f1f1f;
--ion-tab-bar-background: #1f1f1f;
--ion-tab-bar-background-focused: #1b1b1b;
--ion-card-background: #1e1e1e;

/// Only the item borders should increase in contrast
Expand Down
Loading