Skip to content

test(components): scope screenshots to content#31048

Open
ManthanBhatt wants to merge 1 commit intoionic-team:mainfrom
ManthanBhatt:fix-toolbar-screeshot-scope
Open

test(components): scope screenshots to content#31048
ManthanBhatt wants to merge 1 commit intoionic-team:mainfrom
ManthanBhatt:fix-toolbar-screeshot-scope

Conversation

@ManthanBhatt
Copy link
Copy Markdown

@ManthanBhatt ManthanBhatt commented Mar 30, 2026

Issue number: resolves #30422


What is the current behavior?

Several screenshot tests capture the full page even though the ion-toolbar in the header is only present to label the test page. As a result, visual changes to ion-toolbar force unrelated screenshot updates.

What is the new behavior?

This scopes an initial batch of screenshot assertions to ion-content so the toolbar is no longer included in screenshots where its appearance is not being tested.

  • update badge basic screenshot coverage
  • update several button screenshot tests
  • update list-header, progress-bar, and toggle sizes screenshot tests

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • Added no new test cases; this updates existing screenshot assertions to better target the component under test.
  • px eslint passed for the touched files.
  • Playwright screenshot tests were not run locally because the required Playwright browser binaries are not installed in this environment.

@ManthanBhatt ManthanBhatt requested a review from a team as a code owner March 30, 2026 14:15
@github-actions github-actions bot added the package: core @ionic/core package label Mar 30, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

@ManthanBhatt is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter

1 participant