fix(accordion-group): skip initial animation #30729
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@ShaneK Thanks for fixing this! It looks great in the main react use examples, but I did find the following case where it doesn't animate initially. It used to work before but maybe I'm not doing things right I just wanted to let you know :P https://stackblitz.com/edit/dbaxphvw-jt3durvs?file=src%2Fmain.tsx |
Excellent catch, new dev build should address this. |
|
Thanks works great! |
| const firstAccordion = accordionGroup.querySelector('ion-accordion[value="first"]')!; | ||
|
|
||
| expect(firstAccordion.classList.contains('accordion-expanded')).toEqual(true); | ||
| expect(firstAccordion.classList.contains('accordion-expanding')).toEqual(false); |
There was a problem hiding this comment.
I didn't realize that spec tests capture these kinds of classes. I would have expected it to be false all the time since expect would run after the animation ended. I'll have to keep this in mind for future tests. Thanks!
Okay, I think I've got it! New dev build: |
3 participants
Issue number: resolves #30613
What is the current behavior?
Currently, when you load an accordion group, the initially selected accordion animates open. This is an unexpected change caused by upgrading Stencil to >= 4.21.0, which changed the way component lifecycles got triggered.
What is the new behavior?
With this change, we're waiting for the accordion in the accordion group to render and telling it if the update it's going through is the initial update or not. This allows it to decide to animate properly.
Does this introduce a breaking change?
Other information
Current dev build: